[ns] Possible bugs affecting ZRP

[Robin Poss <robin_poss@yahoo.com>]

Hello, 
In zrp.cc the line

fprintf (stderr, CURRENT_TIME);

can cause TCL scripts to abort, because something is
directed to the stream stderr, so TCL thinks an error
occured (Thanks to Alvin C. Valera).
Just delete or comment out this line to solve the
problem.
Also the bug found by Lars Christensen in rtqueue.cc
should affect ZRP as well. See his message (and fix)
below.

Regards, 
--
Robin


***********************************

Hi NS users,

There is a bug in rtqueue.cc that is triggered when NS
is compiled with
the NDEBUG macro defined during preprocessing. In line
147, remove_head()
is called inside an assert(...) statement and is
therefor left out if
compiled with -DNDEBUG, which autoconf in some cases
chooses to do.

The effect is that the simulation loops forever,
printing the same line to
the trace file when e.g. AODV flushes queued packets
due to route request
timeout.

diff -r1.1.1.1 rtqueue.cc
147c147,148
<                 assert(p == remove_head());
---
>               Packet *oldhead = remove_head();
>               assert(p == oldhead);


-- 
Lars Christensen, larsch@cs.auc.dk



__________________________________________________
Do You Yahoo!?
Spot the hottest trends in music, movies, and more.
http://buzz.yahoo.com/