Bug in sfq.cc ?

[Roman A Pletka <roman.pletka@switzerland.org>]

Hi,

I use ns-2.1b4a. There seems to be a baug in sfq.cc line 161:

int SFQ::command(int argc, const char*const* argv)
{
  if (argc == 3) {
    if (strcmp(argv[1], "limit") == 0) {
      maxqueue_ = atoi(argv[2]);
      fairshare = maxqueue_ / buckets_;
      return (TCL_OK);
    }
    if (strcmp(argv[1], "buckets") == 0) {
      clear();
      maxqueue_ = atoi(argv[2]);
      return (TCL_OK);
    }
  }
  return (Queue::command(argc, argv));
}

The second time "maxqueue_ = atoi(argv[2]);" should be "buckets_ = ..."

Romanb

-- 
--------------------------------------------------------
Roman Pletka                roman.pletka@switzerland.org
c/o Sanitas P2/213                         Bruggeregg 19
CH-8802 Kilchberg                        CH-9100 Herisau
Office: ++41 (0)724 89 76      Tf.: ++41-(0)71 352 28 62
Home:   ++41 (0)716 72 32      Fax: ++41-(0)71 352 48 62
* *  Also on WWW: http://studwww.eurecom.fr/~pletka  * *
--------------------------------------------------------