Re: Bug in sfq.cc ?

[Curtis Villamizar <curtis@brookfield.ans.net>]

In message <36B6B632.C220CDB5@switzerland.org>, Roman A Pletka writes:
> Hi,
> 
> I use ns-2.1b4a. There seems to be a baug in sfq.cc line 161:
> 
> int SFQ::command(int argc, const char*const* argv)
> {
>   if (argc == 3) {
>     if (strcmp(argv[1], "limit") == 0) {
>       maxqueue_ = atoi(argv[2]);
>       fairshare = maxqueue_ / buckets_;
>       return (TCL_OK);
>     }
>     if (strcmp(argv[1], "buckets") == 0) {
>       clear();
>       maxqueue_ = atoi(argv[2]);
>       return (TCL_OK);
>     }
>   }
>   return (Queue::command(argc, argv));
> }
> 
> The second time "maxqueue_ = atoi(argv[2]);" should be "buckets_ = ..."
> 
> Romanb

Roman,

Right.

btw- that code was intended as a quick hack and somehow made it into
the distribution.  A rewrite is badly needed.

Curtis